[PATCH] D142330: [AssumptionCache] caches @llvm.experimental.guard's

Joshua Cao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 00:04:57 PST 2023


caojoshua added a comment.

> @caojoshua I wonder, are you using guards for some reason?

No, I don't have specific use cases for guards not using guards, I just saw inconsistencies between how we handle assumptions and guards, and I thought this would be a nice code cleanup. I did not anticipate an increase in compile time.

I think both of nikic's guesses are entirely reasonable. Having information on which passes has the most slowdowns would be very helpful.

If helpful, I would not mind reverting this change. We can revisit this idea. Or since we would like to move away from guards, we could forget about this change all together.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142330/new/

https://reviews.llvm.org/D142330



More information about the llvm-commits mailing list