[PATCH] D142330: [AssumptionCache] caches @llvm.experimental.guard's

Wed Feb 15 23:48:44 PST 2023

nikic added a comment.

In D142330#4131091 <https://reviews.llvm.org/D142330#4131091>, @mkazantsev wrote:

> This chance has caused us a huge compile time degradation.

Oh, that's surprising. I would have expected this to be a compile-time improvement. Do you have any information on where the slowdown is coming from?

I have two guesses:

- We have a number of places manually handling guards, and these might now end up handling guards both explicitly and via AssumptionCache, doing duplicate work. This would be easy to fix by just deleting the guard code.
- This automatically supports guards everywhere assumes are supported, so maybe we now have a lot more places handling guards.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142330/new/

https://reviews.llvm.org/D142330