[PATCH] D143982: [RISCV][CodeGen] Add codegen pattern for experimental zfa extension (FLI and FCVTMOD not included)

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 15 23:46:59 PST 2023


asb added a comment.

In D143982#4126556 <https://reviews.llvm.org/D143982#4126556>, @asb wrote:

> I think function renaming was missed in half-zfa.ll.

It looks like this was addressed in the committed version - thanks!

> Also, most of these tests have the same output for RV32 and RV64, so would benefit from having common CHECK prefixes for them both (e.g. CHECKIZFA), so visual inspection is easier.

I think you might have missed my comment here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143982/new/

https://reviews.llvm.org/D143982



More information about the llvm-commits mailing list