[PATCH] D143982: [RISCV][CodeGen] Add codegen pattern for experimental zfa extension (FLI and FCVTMOD not included)
Jun Sha via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 15 23:02:39 PST 2023
joshua-arch1 added a comment.
In D143982#4131071 <https://reviews.llvm.org/D143982#4131071>, @jrtc27 wrote:
> In D143982#4125543 <https://reviews.llvm.org/D143982#4125543>, @jrtc27 wrote:
>
>> You don’t need to mention FCVTMOD given it does not apply to C/C++.
>
> This was not fixed in the committed version, nor was the Differential Revision: link included, nor reviewer information. Please use arc patch/amend appropriately in future, it's annoying when commits don't have this information as it's a hassle to have to go back and find the right revision manually.
I see. I'll pay attention next time.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143982/new/
https://reviews.llvm.org/D143982
More information about the llvm-commits
mailing list