[PATCH] D144154: [X86]Use Class to refactor ArithMetic td file in X86

Wang, Xin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 15 18:32:44 PST 2023


XinWang10 added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrArithmetic.td:57
 /// register class and preferred load to use.
 class X86TypeInfo<ValueType vt, string instrsuffix, RegisterClass regclass,
                   PatFrag loadnode, X86MemOperand memoperand, ImmType immkind,
----------------
skan wrote:
> This class looks common, could we move it to X86InstrFormats..td?
I find now this class is only used in X86InstrArithmetic.td


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144154/new/

https://reviews.llvm.org/D144154



More information about the llvm-commits mailing list