[PATCH] D144154: [X86]Use Class to refactor ArithMetic td file in X86
Kan Shengchen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 15 18:31:28 PST 2023
skan added inline comments.
================
Comment at: llvm/lib/Target/X86/X86InstrArithmetic.td:460
+// UnaryOpR - Instructions like "inc reg"
+class UnaryOpR<bits<8> opcode, Format f, string mnemonic, X86TypeInfo info,
+ list<dag> pattern>
----------------
It seems this class is never used?
================
Comment at: llvm/lib/Target/X86/X86InstrArithmetic.td:741
+let Defs = [AX,DX,EFLAGS], Uses = [AX] in
+def IMUL16r : MulOpR<0xF7, MRM5r, "imul", Xi16, WriteIMul16, []>;
+// EAX,EDX = EAX*GR32
----------------
Could we define `MulOpR` as a multiclass and use `defm IMUL`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144154/new/
https://reviews.llvm.org/D144154
More information about the llvm-commits
mailing list