[PATCH] D142254: [X86] Transform vector SET{LE/ULT/ULE} -> SETLT and SET{GE/UGT/UGE} -> SETGT if possible

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D142254#4130325 <https://reviews.llvm.org/D142254#4130325>, @saugustine wrote:

> I think it probably needs to also check if the type is Simple, because the exact assertion that fails is isSimple.
>
> And if I insert a check for isSimple on line 24731, the test does pass.
>
>   if (!BV || !V.getValueType().isSimple())
>
> Not sure if that is the correct fix, but perhaps better than reverting. The test case is huge and buried.

If you think you will able to isolate a test case, I'd say revert then resubmit with test case.

If you don't think thats feasible I'd say adding the isSimple check makes sense.

@craig.topper what do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142254/new/

https://reviews.llvm.org/D142254