[PATCH] D142254: [X86] Transform vector SET{LE/ULT/ULE} -> SETLT and SET{GE/UGT/UGE} -> SETGT if possible

Sterling Augustine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 15 14:18:44 PST 2023


saugustine added a comment.

I think it probably needs to also check if the type is Simple, because the exact assertion that fails is isSimple.

And if I insert a check for isSimple on line 24731, the test does pass.

  if (!BV || !V.getValueType().isSimple())

Not sure if that is the correct fix, but perhaps better than reverting. The test case is huge and buried.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142254/new/

https://reviews.llvm.org/D142254



More information about the llvm-commits mailing list