[PATCH] D143847: [RISCV] Add vendor-defined XTheadMAC (multiply-accumulate) extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM fix those formatting changes.



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoXTHead.td:91
+let Predicates = [HasVendorXTHeadMac], DecoderNamespace = "THeadMac",
+  hasSideEffects = 0, mayLoad = 0, mayStore = 0, isCommutable = 1 in
+class THMulAccumulate_rr<bits<7> funct7, string opcodestr>
----------------
I think I missed it in previous reviews, but `hasSideEffects` should line up with `Predicates` on the previous line. That's the prevailing style in RISCVInstrInfo.td


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoXTHead.td:94
+    : RVInstR<funct7, 0b001, OPC_CUSTOM_0, (outs GPR:$rd_wb),
+                    (ins GPR:$rd, GPR:$rs1, GPR:$rs2),
+		    opcodestr, "$rd, $rs1, $rs2"> {
----------------
`(ins` is over indented


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143847/new/

https://reviews.llvm.org/D143847