[PATCH] D143982: [RISCV][CodeGen] Add codegen pattern for experimental zfa extension (FLI and FCVTMOD not included)

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 14 09:52:30 PST 2023


asb added a comment.

I think function renaming was missed in half-zfa.ll.

Also, most of these tests have the same output for RV32 and RV64, so would benefit from having common CHECK prefixes for them both (e.g. CHECKIZFA), so visual inspection is easier.



================
Comment at: llvm/test/CodeGen/RISCV/half-zfa.ll:9
+
+define half @fminm_d(half %a, half %b) nounwind {
+; RV32IHZFA-LABEL: fminm_d:
----------------
The tests in this file should presumable be e.g. fminm_h rather than e.g. fminm_d (seems to be a repeated mistake elsewhere in this file).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143982/new/

https://reviews.llvm.org/D143982



More information about the llvm-commits mailing list