[PATCH] D144001: [Metarenamer] Use 'val' as default name for instructions

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 14 04:51:54 PST 2023


mkazantsev created this revision.
mkazantsev added reviewers: nikic, dmakogon, davide, bryantatnvidia.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
mkazantsev requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Currently we use 'tmp', which is also a keyford for FileCheck. It leads to this
annoying warning whenever a script for auto-generation of checks is used.
It is especially annoying that it happens to every test affected by metarenamer.

Just use another prefix for metarenamed names to avoid this.


https://reviews.llvm.org/D144001

Files:
  llvm/lib/Transforms/Utils/MetaRenamer.cpp


Index: llvm/lib/Transforms/Utils/MetaRenamer.cpp
===================================================================
--- llvm/lib/Transforms/Utils/MetaRenamer.cpp
+++ llvm/lib/Transforms/Utils/MetaRenamer.cpp
@@ -115,7 +115,7 @@
 
     for (auto &I : BB)
       if (!I.getType()->isVoidTy())
-        I.setName("tmp");
+        I.setName("val");
   }
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144001.497275.patch
Type: text/x-patch
Size: 356 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230214/533137bf/attachment.bin>


More information about the llvm-commits mailing list