[PATCH] D143729: [mlir][MemRef][TransformOps] Fix error reporting for multibuffer

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet marked an inline comment as done.
qcolombet added inline comments.


================
Comment at: mlir/lib/Dialect/MemRef/TransformOps/MemRefTransformOps.cpp:29
   if (failed(newBuffer)) {
-    Diagnostic diag(target->getLoc(), DiagnosticSeverity::Note);
+    Diagnostic diag(target->getLoc(), DiagnosticSeverity::Remark);
     diag << "op failed to multibuffer";
----------------
ftynse wrote:
> qcolombet wrote:
> > nicolasvasilache wrote:
> > > qcolombet wrote:
> > > > ftynse wrote:
> > > > > We now have `emitSilenceableError() << "message"`, no need to do the creation dance manually here.
> > > > Ah cool!
> > > > Let me adopt that.
> > > Don't hesitate to clean a few other things as you go: usage has not been consistently improved as you can see ..
> > > 
> > > Thank you!
> > @ftynse  @nicolasvasilache 
> > Should we introduce a `emitSilenceableRemark`?
> > 
> > Scanning through the code, it looks like we still use the old style in a few places, and sometimes we emit `Remark` not `Error` and I don't know if we want to promote these to errors.
> > E.g.,
> > https://github.com/llvm/llvm-project/blob/af39acda8873cc75db116e326588447f018a99d9/mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp#L668
> Places that emit Remark are wrong and should emit Error instead.
Changed that in https://github.com/llvm/llvm-project.git
   2a58be423963..5a028cc8ffa5  main -> main


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143729/new/

https://reviews.llvm.org/D143729