[PATCH] D143731: [AMDGPU] Scalarize some large PHIs for DAGISel

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 07:22:56 PST 2023


Pierre-vh added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-scalarize-large-phis.ll:612
+  ret void
+}
----------------
arsenm wrote:
> Should also include some FP, 8-bit and 16-bit element cases. We’d be bette riff breaking those into 32 or 64 bit pieces than full scalarization
Should I also lower the threshold for this to kick in? Else 8 bit vectors won't be interesting unless they're >32 elts


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143731/new/

https://reviews.llvm.org/D143731



More information about the llvm-commits mailing list