[PATCH] D143731: [AMDGPU] Scalarize some large PHIs for DAGISel

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 06:25:23 PST 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp:1353
+            ConstantAsMetadata::get(
+                ConstantInt::get(I32Ty, Lower->getValue().zext(32))),
+            // Don't make assumptions about the high bits.
----------------
Pierre-vh wrote:
> arsenm wrote:
> > A few random formatting changes 
> Is it fine if I run clang-format on this file and commit the result directly to get rid of them?
If you use git clang-format it only touches diffed lines 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143731/new/

https://reviews.llvm.org/D143731



More information about the llvm-commits mailing list