[PATCH] D143029: [RISCV] Add vendor-defined XTHeadBa (address-generation) extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM other than test comment.



================
Comment at: llvm/test/MC/RISCV/XTHeadBa-valid.s:1
+# With XTHeadBa (bitmanip base) extension:
+# RUN: llvm-mc %s -triple=riscv32 -mattr=+xtheadba -show-encoding \
----------------
"base" is wrong here, isn't it? This is the addressing extension. Is it wrong in the Zba test too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143029/new/

https://reviews.llvm.org/D143029