[PATCH] D143029: [RISCV] Add vendor-defined XTHeadBa (address-generation) extension

[Philipp Tomsich via Phabricator via llvm-commits]

philipp.tomsich added inline comments.


================
Comment at: llvm/test/MC/RISCV/rv32xtheadba-valid.s:1
+# With Bitmanip base extension:
+# RUN: llvm-mc %s -triple=riscv32 -mattr=+xtheadba -show-encoding \
----------------
craig.topper wrote:
> I think this "Bitmanip base" was copied from Zbb? Should we adjust it to include T-Head?
This can't be merged, as the mnemonics are different.
Updated the comment. 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143029/new/

https://reviews.llvm.org/D143029