[PATCH] D143029: [RISCV] Add vendor-defined XTHeadBa (address-generation) extension

[Philipp Tomsich via Phabricator via llvm-commits]

philipp.tomsich added inline comments.


================
Comment at: llvm/test/MC/RISCV/XTHeadBa-valid.s:1
+# With XTHeadBa (bitmanip base) extension:
+# RUN: llvm-mc %s -triple=riscv32 -mattr=+xtheadba -show-encoding \
----------------
craig.topper wrote:
> "base" is wrong here, isn't it? This is the addressing extension. Is it wrong in the Zba test too?
Yes, it is wrong in the Zba tests: I'll send up NFC patches for those.

That said: I admire your attention to detail.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143029/new/

https://reviews.llvm.org/D143029