[PATCH] D143320: [bazel] Rework zlib dependency

[Aaron Siddhartha Mondal via Phabricator via llvm-commits]

aaronmondal added a comment.

In D143320#4108196 <https://reviews.llvm.org/D143320#4108196>, @GMNGeoffrey wrote:

> You'd add `-lz` as was here previously and let the system handle it. Definitely don't want to reinvent system package search here :-)

This only works if `-L<path_to_lib>` is set and may cause inconsistencies in some shells and environments (like Nix), where it becomes unclear whether we are linking `-L/usr/lib` or `-L/veryesotericpath`. If that path is unknown or disabled things don't work at all. So far I haven't found a way to "query" for these standard library paths please let me know if there is some some config file or something that I'm not aware of. This is causing me so many headaches.

Regarding the WORKSPACE logic, that sounds good. I'll try to get something like that working but that may take me a while. Tbh I'm not really using WORKSPACES myself and instead using the bzlmod patch series that I tried upstreaming a while ago but I think they got kinda dropped and would probably need some rework at this point. (A working bazel module for a registry is here <https://github.com/eomii/bazel-eomii-registry/tree/main/modules/llvm-project-overlay/17-init-bcr.0> with sample usage here <https://github.com/eomii/rules_ll/blob/d451cb2ab5efb3ea1a86c5a40aca7f545043ec8c/MODULE.bazel#L25>).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143320/new/

https://reviews.llvm.org/D143320