[PATCH] D143320: [bazel] Rework zlib dependency

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added inline comments.


================
Comment at: utils/bazel/WORKSPACE:38
 maybe(
     http_archive,
+    name = "llvm_zlib",
----------------
aaronmondal wrote:
> GMNGeoffrey wrote:
> > Somewhat orthogonal to your change, but last week's GitHub sha256 blowup reminded me that `http_archive` is horrible and we should probably switch to using `git_repository`
> It turned out that GitHub actually does guarantee sha stability, but only for release tag links. This *really* screwed all our workflows.
> 
> I'd love changing this (and all other http archives), but I think it should be handled in a different commit, since it may break CI environments without git.
Well I think even there it was just that at some point someone said they would be stable maybe, but obviously didn't communicate that to the team who was actually able to control that :-P Anyway, agreed on it being a separate commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143320/new/

https://reviews.llvm.org/D143320