[PATCH] D143320: [bazel] Rework zlib dependency

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 17:00:22 PST 2023


GMNGeoffrey added a comment.

In D143320#4108552 <https://reviews.llvm.org/D143320#4108552>, @aaronmondal wrote:

> Regarding the WORKSPACE logic, that sounds good. I'll try to get something like that working but that may take me a while. Tbh I'm not really using WORKSPACES myself and instead using the bzlmod patch series that I tried upstreaming a while ago but I think they got kinda dropped and would probably need some rework at this point. (A working bazel module for a registry is here <https://github.com/eomii/bazel-eomii-registry/tree/main/modules/llvm-project-overlay/17-init-bcr.0> with sample usage here <https://github.com/eomii/rules_ll/blob/d451cb2ab5efb3ea1a86c5a40aca7f545043ec8c/MODULE.bazel#L25>).

Ugh that's my bad. I totally forgot about those :-( I think it enforced naming of the `llvm-project` repo in a way I found unsavory and I never figured out a solution after getting very lost in what `Label` appears to do vs what I think the documentation says it does...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143320/new/

https://reviews.llvm.org/D143320



More information about the llvm-commits mailing list