[PATCH] D142482: [Codegen] Support symmetric operations on complex numbers

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:655
 
+  LLVM_DEBUG(dbgs() << " - RotKey: " << RotKey << ".\n");
+
----------------
This needn't be here.


================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:723
+ComplexDeinterleavingGraph::identifySymmetricOperation(Instruction *Real,
+                                                Instruction *Imag) {
+  if(Real->getOpcode() != Imag->getOpcode())
----------------
Formatting


================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:855
+  if (RealShuffle || ImagShuffle) {
+    LLVM_DEBUG(dbgs() << " - There's a shuffle where there shouldn't be.\n");
     return nullptr;
----------------
This could be in the other cleanup patch.


================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:911
 
+static Value* replaceSymmetricNode(ComplexDeinterleavingGraph::RawNodePtr Node, Value* InputA, Value* InputB) {
+  Instruction* I = Node->Real;
----------------
Formatting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142482/new/

https://reviews.llvm.org/D142482