[PATCH] D143177: Cleanup of Complex Deinterleaving pass (NFCI)

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:642-656
+  unsigned RotKey = 0;
+  RotKey |= Real->getOpcode() == Instruction::FSub ||
+            Real->getOpcode() == Instruction::Sub;
+  RotKey |= ((Imag->getOpcode() == Instruction::FSub ||
+              Imag->getOpcode() == Instruction::Sub)
+             << 1);
+  if ((RotKey & 2) == 2)
----------------
I think I find the existing code easier to follow and read. And it is more explicit about matching adds. Neither are super pretty, but I think I would recommend keeping what was there before.


================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:857
+  Value *Input1 =
+      Node->Operands.size() > 1 ? replaceNode(Node->Operands[1]) : nullptr;
   Value *Accumulator =
----------------
This could actually be part of the other patch, if it the first part to introduce single element nodes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143177/new/

https://reviews.llvm.org/D143177