[PATCH] D143106: [SDAG] fix miscompiles caused by using ValueTracking matchSelectPattern to create FMINIMUM/FMAXIMUM

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 05:16:28 PST 2023


samparker added a comment.

> Can you preserve the match with nsz?

I'm not sure I follow why signalling is important here? I've noticed that we'll lower FMINNUM to FMINIMUM, in TargetLowering::expandFMINNUM_FMAXNUM, in the absence of //any// NaNs - but that also doesn't appear to respect the +/-0 issue raised here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143106/new/

https://reviews.llvm.org/D143106



More information about the llvm-commits mailing list