[PATCH] D143106: [SDAG] fix miscompiles caused by using ValueTracking matchSelectPattern to create FMINIMUM/FMAXIMUM

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 02:56:43 PST 2023


arsenm added a comment.

Can you preserve the match with nsz?

I think we need to just rename FMINNUM to FMIN, and have explicit FMINNUM_IEEE2008 (with snan handling and unspecified -0 vs. 0, or whatever version these were introduced), and FMINNUM_IEEE2019 (with specified +0 vs. 0)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143106/new/

https://reviews.llvm.org/D143106



More information about the llvm-commits mailing list