[PATCH] D143106: [SDAG] fix miscompiles caused by using ValueTracking matchSelectPattern to create FMINIMUM/FMAXIMUM
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 2 05:30:08 PST 2023
arsenm added a comment.
In D143106#4099451 <https://reviews.llvm.org/D143106#4099451>, @samparker wrote:
>> Can you preserve the match with nsz?
>
> I'm not sure I follow why signalling is important here?
I didn’t say it was, but changing from select to a min introduces quieting which wouldn’t happen before
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143106/new/
https://reviews.llvm.org/D143106
More information about the llvm-commits
mailing list