[PATCH] D142020: AMDGPU: Partially fix machine uniformity for inline asm

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added a comment.

No more comments from me but I don't have enough experience with uniformity analysis to approve



================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:8407-8416
+  unsigned opcode = MI.getOpcode();
+  if (MI.isCopy()) {
+    const MachineOperand &srcOp = MI.getOperand(1);
+    if (srcOp.isReg() && srcOp.getReg().isPhysical()) {
+      const TargetRegisterClass *regClass =
+          RI.getPhysRegBaseClass(srcOp.getReg());
+      return RI.isSGPRClass(regClass) ? InstructionUniformity::AlwaysUniform
----------------
Variable names need to start with an upper case letter


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142020/new/

https://reviews.llvm.org/D142020