[PATCH] D142220: AMDGPU/GlobalISel: Partially fix getGenericInstructionUniformity

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added a comment.

LGTM but I will leave it up to someone with experience with uniformity analysis to approve



================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:8388
+    case Intrinsic::amdgcn_else:
+      // FIXME: Uniform if second result
+      break;
----------------
nit: If I understand correctly we would need an extra parameter to `getGenericInstructionUniformity` in order to handle this case, right?
Perhaps add that to the comment to make it clear that the API as-is doesn't give us enough information to tell?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142220/new/

https://reviews.llvm.org/D142220