[PATCH] D142248: [lld-macho] Do not warn on missing /usr/local/lib library search path

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

> We do handle systemPaths as optional right now in L186-L194. The issue is that the link arguments contain an explicit -L/usr/local/lib that doesn't exist.

I understand. I was thinking that the system path is optional even when explicitly specified, hence `optionalSystemPath`. Maybe `strictlyOptionalSystemPath`? But I can see that it might be confusing.

Not a fan of hardcoded paths, but as long as there's an explanatory comment I suppose it's fine.

> AFAICT, I can't test the universally test the latter behavior because that relies on having a non-existent /usr/local/lib directory

Ah I was under the impression that it would be looking up `$syslibroot/usr/local/lib`, but I see now that it is looking up the non-rerooted path. Fair enough then, this does seem untestable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142248/new/

https://reviews.llvm.org/D142248