[PATCH] D142248: [lld-macho] Do not warn on missing /usr/local/lib library search path

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 12:27:54 PST 2023


oontvoo added a comment.

In D142248#4074581 <https://reviews.llvm.org/D142248#4074581>, @thevinster wrote:

>> Also, could we have a test?
>
> I'm not sure of a good way to test this because I'm trying to test the scenario that passing in `-L/usr/local/lib` that doesn't exist on the host doesn't result in a warning (and when passing `-L/usr/local/lib` with `-Z`, it does result in a warning). AFAICT, I can't test the universally test the latter behavior because that relies on having a non-existent `/usr/local/lib` directory (which most developer machines will almost be guaranteed to have). I can create a test for the former. It'll be no-op for the most developers since developers will have the directory, but if not, the behavior should be the same.

Would having this test run only on windows be helpful?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142248/new/

https://reviews.llvm.org/D142248



More information about the llvm-commits mailing list