[PATCH] D142248: [lld-macho] Do not warn on missing /usr/local/lib library search path

[Vincent Lee via Phabricator via llvm-commits]

thevinster added a comment.

We do handle systemPaths as optional right now in L186-L194. The issue is that the link arguments contain an explicit `-L/usr/local/lib` that doesn't exist.

> Looks like /Library/Frameworks is treated similarly.

I can add that as an extra condition as well.

> Also, could we have a test?

I'm not sure of a good way to test this because I'm trying to test the scenario that passing in `-L/usr/local/lib` that doesn't exist on the host doesn't result in a warning (and when passing `-L/usr/local/lib` with `-Z`, it does result in a warning). AFAICT, I can't test the universally test the latter behavior because that relies on having a non-existent `/usr/local/lib` directory (which most developer machines will almost be guaranteed to have). I can create a test for the former. It'll be no-op for the most developers since developers will have the directory, but if not, the behavior should be the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142248/new/

https://reviews.llvm.org/D142248