[PATCH] D142283: [Support] Make llvm-symbolizer runs for stack traces work on Apple platforms

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 21 07:15:28 PST 2023


luismarques added inline comments.


================
Comment at: llvm/lib/Support/Signals.cpp:207
+
+#if defined(__APPLE__) && defined(__LP64__)
+  // Find all of the .dSYM bundles in the LLVM build directory and pass each of
----------------
The `__LP64__` check is not strictly necessary, but running this code is pointless until the `findModulesAndOffsets` implementation also runs on 32-bit Apple platforms.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142283/new/

https://reviews.llvm.org/D142283



More information about the llvm-commits mailing list