[PATCH] D142216: [MC] Store number of implicit operands in MCInstrDesc. NFC.

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 08:39:56 PST 2023


barannikov88 added inline comments.


================
Comment at: llvm/utils/TableGen/InstrInfoEmitter.cpp:1190
+  // Emit the implicit use/def list...
+  llvm::append_range(UseList, DefList);
   if (UseList.empty())
----------------
I understand that the intent is to reduce code duplication, but appending Defs to Uses looks awkward.
Can it use `llvm::concat_range`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142216/new/

https://reviews.llvm.org/D142216



More information about the llvm-commits mailing list