[PATCH] D142216: [MC] Store number of implicit operands in MCInstrDesc. NFC.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 20 07:59:43 PST 2023
arsenm added inline comments.
================
Comment at: llvm/utils/TableGen/InstrInfoEmitter.cpp:911-912
Record *Inst = II->TheDef;
- std::vector<Record*> Uses = Inst->getValueAsListOfDefs("Uses");
+ std::vector<Record *> Uses = Inst->getValueAsListOfDefs("Uses");
+ std::vector<Record *> Defs = Inst->getValueAsListOfDefs("Defs");
+ llvm::append_range(Uses, Defs);
----------------
Does this really need to generate a copy of vector for every instruction/
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142216/new/
https://reviews.llvm.org/D142216
More information about the llvm-commits
mailing list