[PATCH] D141830: Invalid alignment specification For NVPTX LowerFormalArguments
Guillaume Chatelet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 19 00:50:11 PST 2023
gchatelet added a comment.
Thx for the response!
As of this revision <https://reviews.llvm.org/D141830?vs=on&id=489739#toc> the patch is absolutely useless, you're right. I wanted to be sure of the intended semantic before switching this call to the new `getLoad` function.
AFAIR there is a risk for a `bool` value to be `true` but hold a value that is not `1`. Also it felt suspicious to pass a `bool` in lieu of an `unsigned` so I just wanted to be absolutely sure it was not a mistake.
I'll upload the //real// patch shortly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141830/new/
https://reviews.llvm.org/D141830
More information about the llvm-commits
mailing list