[PATCH] D141830: Invalid alignment specification For NVPTX LowerFormalArguments

[Artem Belevich via Phabricator via llvm-commits]

tra added a comment.

> let me know if someone is a better fit for this review.

You've reached the right audience. :-)

> I don't know if the current behavior is expected or not so the fix may change.

The original code looks OK to me. If the aggregate is packed, we request alignment of 1. If the `bool aggregateIsPacked` is true, it will undergo implicit integer conversion to 1, otherwise, we don't specify the alignment (0). AFAICT it should work exactly the same way before and after your patch and call exactly the same overload with exactly the same values. It's possible I'm missing something, but I do not see it at the moment.

It would help if you could provide more details about the problem you're trying to solve. A simple reproduced on godbolt.org would be very helpful.

Can you add a test that would demonstrate the issue with the current code and how the results would look like after the fix?

As things stand, I can't say I understand what exactly is the problem you want to fix, nor how the patch changes anything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141830/new/

https://reviews.llvm.org/D141830