[PATCH] D141258: [AArch64] Fix crash for expandMOVImm

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 15:29:16 PST 2023

Previous message: [llvm] 3d6841b - [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number.
Next message: [PATCH] D141258: [AArch64] Fix crash for expandMOVImm
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

efriedma added a comment.

I'd rather stick the bitsize check in the caller, AArch64TargetLowering::isMulAddWithConstProfitable; without that context, it isn't clear why the bitwidth should be modified this way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141258/new/

https://reviews.llvm.org/D141258

Previous message: [llvm] 3d6841b - [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number.
Next message: [PATCH] D141258: [AArch64] Fix crash for expandMOVImm
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list