[PATCH] D140654: [MC] Use MCRegister instead of unsigned in MCInstPrinter (NFC)

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 09:12:19 PST 2023


barannikov88 added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp:46
   // non-pretty DWARF register names in assembly text.
-  OS << RegNo;
+  OS << Reg;
 }
----------------
craig.topper wrote:
> Use `Reg.id()` here so we don't have to come back and fix it if ever get rid of `operator unsigned`?
Good idea, will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140654/new/

https://reviews.llvm.org/D140654



More information about the llvm-commits mailing list