[PATCH] D140654: [MC] Use MCRegister instead of unsigned in MCInstPrinter (NFC)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp:46
   // non-pretty DWARF register names in assembly text.
-  OS << RegNo;
+  OS << Reg;
 }
----------------
Use `Reg.id()` here so we don't have to come back and fix it if ever get rid of `operator unsigned`?


================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyInstPrinter.cpp:43
+                                          MCRegister Reg) const {
+  assert(Reg != WebAssemblyFunctionInfo::UnusedReg);
   // Note that there's an implicit local.get/local.set here!
----------------
Reg.id()


================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyInstPrinter.cpp:45
   // Note that there's an implicit local.get/local.set here!
-  OS << "$" << RegNo;
+  OS << "$" << Reg;
 }
----------------
Reg.id()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140654/new/

https://reviews.llvm.org/D140654