[PATCH] D141912: [AsmParser] Remove typed pointer auto-detection

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/lower-kernel-lds.ll:2
+; RUN: opt -opaque-pointers=0 -S -mtriple=amdgcn-- -amdgpu-lower-module-lds --amdgpu-lower-module-lds-strategy=module < %s | FileCheck %s
+; RUN: opt -opaque-pointers=0 -S -mtriple=amdgcn-- -passes=amdgpu-lower-module-lds --amdgpu-lower-module-lds-strategy=module < %s | FileCheck %s
 
----------------
arsenm wrote:
> The test diff is bigger than I expected, what is holding this set of tests back? For example these AMDGPU tests weren't converted with the others to avoid a merge conflict issue which we're past now
Just a matter of time. I want to land this change before LLVM 16 branches, and don't have time to convert all the remaining tests.

I haven't looked into AMDGPU tests in particular because I assumed that you are taking care of them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141912/new/

https://reviews.llvm.org/D141912