[PATCH] D141912: [AsmParser] Remove typed pointer auto-detection

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 08:25:27 PST 2023


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/lower-kernel-lds.ll:2
+; RUN: opt -opaque-pointers=0 -S -mtriple=amdgcn-- -amdgpu-lower-module-lds --amdgpu-lower-module-lds-strategy=module < %s | FileCheck %s
+; RUN: opt -opaque-pointers=0 -S -mtriple=amdgcn-- -passes=amdgpu-lower-module-lds --amdgpu-lower-module-lds-strategy=module < %s | FileCheck %s
 
----------------
The test diff is bigger than I expected, what is holding this set of tests back? For example these AMDGPU tests weren't converted with the others to avoid a merge conflict issue which we're past now


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141912/new/

https://reviews.llvm.org/D141912



More information about the llvm-commits mailing list