[PATCH] D140848: [VPlan] Remove duplicated VPValue IDs (NFCI).

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 489812.
fhahn marked 2 inline comments as done.
fhahn added a comment.

Rebase before landing.

In D140848#4056972 <https://reviews.llvm.org/D140848#4056972>, @Ayal wrote:

> OK, thanks for clarifying.
> It's somewhat confusing to have the order of parameters dictate which VPValue is being constructed, but the alternative of having each subclass provide its VPDefID seems less appealing.
> Perhaps once a common base class is introduced to take care of all recipes that also inherit from VPValue it could pass VPVRecipeSC explicitly when constructing VPValue, rather than relying on this order.

A common base class for recipes inheriting from VPValue may be a good way forward. I'll look into this as follow-up!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140848/new/

https://reviews.llvm.org/D140848

Files:
  llvm/lib/Transforms/Vectorize/VPlan.h
  llvm/lib/Transforms/Vectorize/VPlanValue.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140848.489812.patch
Type: text/x-patch
Size: 19591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230117/938592d6/attachment.bin>