[PATCH] D140848: [VPlan] Remove duplicated VPValue IDs (NFCI).

[Ayal Zaks via Phabricator via llvm-commits]

Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

OK, thanks for clarifying.
It's somewhat confusing to have the order of parameters dictate which VPValue is being constructed, but the alternative of having each subclass provide its VPDefID seems less appealing.
Perhaps once a common base class is introduced to take care of all recipes that also inherit from VPValue it could pass VPVRecipeSC explicitly when constructing VPValue, rather than relying on this order.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140848/new/

https://reviews.llvm.org/D140848