[PATCH] D141834: [RISCV][NFC] Use uncompressInst to relax instructions

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:178
   case RISCV::C_JAL:
-    // c.jal $imm -> jal X1, $imm.
-    Res.setOpcode(RISCV::JAL);
-    Res.addOperand(MCOperand::createReg(RISCV::X1));
-    Res.addOperand(Inst.getOperand(0));
+    bool Success = RISCVRVC::uncompress(Res, Inst, MRI, STI);
+    assert(Success && "Can't uncompress instruction");
----------------
craig.topper wrote:
> Where is RISCRVC defined?
Never mind I didn’t see the other patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141834/new/

https://reviews.llvm.org/D141834