[PATCH] D141834: [RISCV][NFC] Use uncompressInst to relax instructions

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 00:11:24 PST 2023


pcwang-thead added a comment.

In D141834#4057500 <https://reviews.llvm.org/D141834#4057500>, @craig.topper wrote:

> Can we do this in a way that doesn't replicate the uncompressInst function in two different cpp files.

Thanks, I have thought about it too yesterday. :)
So I moved `compressInst/uncompressInst` to `RISCVBaseInfo` (D141897 <https://reviews.llvm.org/D141897>) and removed all other duplicated code.
Additionally, because there are redefinition errors of `RISCVValidateMCOperand`, so I added postfix to these validators.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141834/new/

https://reviews.llvm.org/D141834



More information about the llvm-commits mailing list