[PATCH] D141485: [X86] Add schedule module for SapphireRapids

Haohai, Wen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 16 23:20:05 PST 2023


HaohaiWen added inline comments.


================
Comment at: llvm/test/CodeGen/X86/pmullq-false-deps.ll:9
+; ENABLE-NEXT:    vmovdqa %xmm1, {{[-0-9]+}}(%r{{[sb]}}p) # 16-byte Spill
+; ENABLE-NEXT:    vpmullq %xmm1, %xmm0, %xmm2
+; ENABLE-NEXT:    vmovdqa %xmm2, {{[-0-9]+}}(%r{{[sb]}}p) # 16-byte Spill
----------------
RKSimon wrote:
> please can you check if this is OK - I can't recall the exact nature of the false-deps issue but shouldn't xmm2 be cleared?
Hi @gpei, could you please help to check this? Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141485/new/

https://reviews.llvm.org/D141485



More information about the llvm-commits mailing list