[PATCH] D141487: [LoopUnroll] Directly update DT instead of DTU.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/BasicBlockUtils.cpp:243
+      for (DomTreeNode *C : to_vector(BBNode->children()))
+        C->setIDom(PredNode);
+    }
----------------
Doesn't this need to check whether the old idom was BB? Couldn't it be higher up?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141487/new/

https://reviews.llvm.org/D141487