[PATCH] D140858: [InstCombine]: Don't simplify bits if it causes imm32 to become imm64

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 07:26:46 PST 2023


goldstein.w.n added a comment.

In D140858#4028085 <https://reviews.llvm.org/D140858#4028085>, @nikic wrote:

> I'm fine with this change, but let's wait for @spatel. The zext->sext changes in induction.ll don't look particularly problematic to me.

Hmm, I was generally in favor of trying to preserve this. Is there opposition to allowing removal of sign bit if it can be used for
`sext` -> `zext` (so imm8 -> imm16/imm32 and imm16 -> imm32)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140858/new/

https://reviews.llvm.org/D140858



More information about the llvm-commits mailing list