[PATCH] D140858: [InstCombine]: Don't simplify bits if it causes imm32 to become imm64

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:68
+      return false;
+  }
+
----------------
lebedev.ri wrote:
> I think we are missing an inverse case.
> If we have some large number, and we don't demand it's sign bits,
> and if setting them allows it to become smaller, we should probably do that.
> I think we are missing an inverse case.
> If we have some large number, and we don't demand it's sign bits,
> and if setting them allows it to become smaller, we should probably do that.

Good catch will check that out in V3.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140858/new/

https://reviews.llvm.org/D140858