[PATCH] D140858: [InstCombine]: Don't simplify bits if it causes imm32 to become imm64

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 06:08:46 PST 2023


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:68
+      return false;
+  }
+
----------------
I think we are missing an inverse case.
If we have some large number, and we don't demand it's sign bits,
and if setting them allows it to become smaller, we should probably do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140858/new/

https://reviews.llvm.org/D140858



More information about the llvm-commits mailing list