[PATCH] D140882: llvm-reduce: Avoid invalid attribute reduction on optnone functions

Tue Jan 3 11:37:12 PST 2023

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

In D140882#4023701 <https://reviews.llvm.org/D140882#4023701>, @arsenm wrote:

> In D140882#4023654 <https://reviews.llvm.org/D140882#4023654>, @jdoerfert wrote:
>
>>> ridiculous restriction
>>
>> +1
>>
>> We should not have that. It's super annoying honestly and does not help at all. Nobody would be any worse off if we remove the assertion. Shouldn't we do that?
>
> Yes but this is an argument I remember losing when optnone was first introduced. optnone cannot be an enforceable semantic and can act like weak noinline on its own

I don't understand, though I vaguely remember trying to remove that assertion myself at some point.

If we don't try to do the right thing anymore, this seems to be the least wrong. LG

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140882/new/

https://reviews.llvm.org/D140882